<AWT Dev> [9] Review Request: 8031090 [macosx] LWToolkit should not depends from the macosx

[Petr Pchelko]

Hello, Sergey.

The fix looks good to me.

With best regards. Petr.

On 15.01.2014, at 16:59, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:

> On 15.01.2014 16:00, Petr Pchelko wrote:
>> Hello, Sergey.
>> 
>> LWToolkit:166 You could add @Override to run()
> Fixed
>> LWCToolkit:80 - The PriveligedAction could be replace with a lambda
> I guess it will be good to replace code to lambda in one separate change.
>> LWCToolkit:364 - Why did you remove the comment?
> This comment is copied from SunToolkit and currently incomplete.
> 
> New version:
> http://cr.openjdk.java.net/~serb/8031090/webrev.01
>> 
>> With best regards. Petr.
>> 
>> On 15.01.2014, at 15:43, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>> 
>>> Hello.
>>> Please review the fix for jdk 9.
>>> - Dependency in LWtoolkit from sun.lwawt.macosx.* was moved to LWCToolkit.
>>> - All unimplemented stubs in LWToolkit were removed.
>>> - @override and final were added where appropriate.
>>> - long lines were split.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8031090
>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8031090/webrev.00
>>> 
>>> -- 
>>> Best regards, Sergey.
>>> 
> 
> 
> -- 
> Best regards, Sergey.
>