<AWT Dev> [9] Review Request: JDK-8030093 Generify DataTrasfer classes

[Anthony Petrov]

Hi Petr,

In a few places in 
src/share/classes/sun/awt/datatransfer/DataTransferer.java you're 
eliminating calls to Integer.valueOf() and instead assign the values 
directly. Note that this causes the auto-boxing to take place 
unconditionally, and thus may hurt the performance a bit. I suggest to 
leave the valueOf() calls as they are to take advantage of the Integer's 
cache. Please refer to the javadoc for this method for more details. The 
same suggestion applies to Long (and maybe Boolean, too?)

--
best regards,
Anthony

On 1/16/2014 11:49 AM, Petr Pchelko wrote:
> Hello, AWT Team.
>
> Please review the fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-8030093
> The fix is available at:
> http://cr.openjdk.java.net/~pchelko/9/8030093/webrev.00/
>
> This is a general refactoring and clean-up for the DataTransferer class. Mostly generefication and replacing for with foreach.
>
> With best regards. Petr.
>