<AWT Dev> [9] Review request for 8049418: [macosx] PopupMenuListener.popupMenuWillBecomeVisible is not called for empty combobox on MacOS/aqua look and feel

[Alexander Zvegintsev]

Petr,

Sure, it returns back.

https://bugs.openjdk.java.net/browse/JDK-8049439

Thanks,

Alexander.

On 07/07/2014 06:35 PM, Petr Pchelko wrote:
> Hi, Alexander.
>
> The fix looks good, just one question. The blinking problem returns back? Could you please file a P4 bug for it?
>
> With best regards. Petr.
>
>> On Jul 7, 2014, at 6:22 PM, Alexander Zvegintsev <alexander.zvegintsev at oracle.com> wrote:
>>
>> Hello,
>>
>> please review the fix
>> http://cr.openjdk.java.net/~azvegint/jdk/9/8049418/00/
>> for the issue
>> https://bugs.openjdk.java.net/browse/JDK-8049418
>>
>>
>> The JDK-8041896 [1] fix consists of two part: actual fix in LWChoicePeer.java and unrelated improvements in AquaComboBoxPopup.java.
>> Changes in AquaComboBoxPopup.java was introduced to remove popup window blinking(it shows for about 0.1 sec and then closes).
>> However this introduce another regression: popupMenuWillBecomeVisible handler is not called for empty combobox.
>>
>> This fix simply reverts AquaComboBoxPopup.java to its previous behavior.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8041896
>>
>> -- 
>> Thanks,
>>
>> Alexander.
>>