<AWT Dev> [9] Review Request for 8043126: move awt automated functional tests from AWT_Events/Lw and AWT_Events/AWT to OpenJDK repository

[alexander stepanov]

Thanks!

On 08.07.2014 15:34, Petr Pchelko wrote:
> Hello, Alexander.
>
> The fix looks good to me.
>
> With best regards. Petr.
>
> On 08 июля 2014 г., at 15:27, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:
>
>> Please see also the updated webrev here: http://cr.openjdk.java.net/~avstepan/8043126/webrev.01/
>>
>> Regards,
>> Alexander
>>
>> On 04.07.2014 19:19, alexander stepanov wrote:
>>> Hello Petr,
>>>
>>>> I'm not quite sure I completely understand why do we need these special helper components.
>>> At the moment we have a lot of functional tests (not only event-related) testing the lightweight components (LWButton, LWList) and having the same test logic as the corresponding tests for AWT components.
>>>
>>> I asked Sergey Bylokhov about them and his opinion (if I understood him correctly) was that the aim of these tests is to check the base functionality for Component class (because the user in principle can derive his own components from it).
>>>
>>> So the final decision was to keep the lightweight components tests and unify them with the tests for corresponding AWT components (to reduce code duplication); - that's all, I didn't have any other special considerations.
>>>
>>> The helper classes weren't refactored deeply (only minor cosmetic changes like formatting / copyright notice) because at the moment it is not clear what methods should be used in future relocation job.
>>>
>>>
>>> With respect to other notes - I'll fix them and post a new webrev, thanks.
>>>
>>> Regards,
>>> Alexander
>>>
>>>
>>>
>>> On 04.07.2014 18:00, Petr Pchelko wrote:
>>>> Hello, Alexander.
>>>>
>>>> Sorry for the delay.
>>>>
>>>> First of all, could you please describe the approach used in these tests. I'm not quite sure
>>>> I completely understand why do we need these special helper components.
>>>>
>>>> Some comments:
>>>> 1. LWList: 32  typo LeightWeight
>>>> 2. MultipleMouseButtonsTest: 219 - you could reuse the robot.type function here. And same comment applies to other tests.
>>>>
>>>> With best regards. Petr.
>>>>
>>>> On 04 июля 2014 г., at 17:10, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:
>>>>
>>>>> Sorry, just a reminder.
>>>>>
>>>>> Regards,
>>>>> Alexander
>>>>>
>>>>> On 09.06.2014 14:57, alexander stepanov wrote:
>>>>>> Sorry, just a reminder.
>>>>>>
>>>>>> Thanks,
>>>>>> Alexander
>>>>>>
>>>>>> On 28.05.2014 15:42, alexander stepanov wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> Could you please review the fix for the following bug:
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8043126
>>>>>>>
>>>>>>> Webrev:
>>>>>>> http://cr.openjdk.java.net/~yan/8043126/webrev.00/
>>>>>>>
>>>>>>> This is a set of functional AWT tests prepared for migration to OpenJDK repository.
>>>>>>>
>>>>>>> Some tests were refactored / unified to reduce code duplication. Lightweight component classes should be added as helpers to test base Component functionality.
>>>>>>>
>>>>>>> The tests were checked on Ubuntu 14.04, Solaris 11, Mac OS X 10.8.5 and Windows 7
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Alexander