<AWT Dev> [9] Review request for 8044444 The output's 'Page-n' footer does not show completely.

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Jul 15 11:28:12 UTC 2014


Hello,

Could you review the fix:
   bug: https://bugs.openjdk.java.net/browse/JDK-8044444
   webrev: http://cr.openjdk.java.net/~alexsch/8044444/webrev.00

   Native method printLoop from CPrinterJob calls 
javaPrinterJobToNSPrintInfo(...) method after 
javaPageFormatToNSPrintInfo(...).
   Both methods set the page size. The initial page size is set in 
defaultPage(PageFormat) method.
   After the fix 8011069 the printDialog() initializes attributes which 
leads that new page size is created in the 
attributeToPageFormat(PrintService, PrintRequestAttributeSet) method.

   The fix changes order of the javaPrinterJobToNSPrintInfo(...) 
javaPageFormatToNSPrintInfo(...) call so initial page size is set at the 
end.

   There is the JCK test that covers the issue.

Thanks,
Alexandr.



More information about the awt-dev mailing list