<AWT Dev> Review request for 8049694: Migrate functional AWT_DesktopProperties/Automated tests to OpenJDK

[Dmitriy Ermashov]

Hi Alexander,

On 07/16/2014 06:37 PM, Alexander Zvegintsev wrote:
> Hi Dmitriy,
>
> Correct me if I am wrong:
> jtreg keeps DISPLAY and strips many environment variables(e.g. 
> DBUS_SESSION_BUS_ADDRESS).
> DBUS_SESSION_BUS_ADDRESS variable is needed for correct work of 
> gconftool-2 and gsettings
> That's why we need pargs and /proc/$PID/environ.
Everything is right.
gconftool-2 and gsettings do not work without DBUS_SESSION_BUS_ADDRESS 
or DISPLAY variable set.
>
> But this test fails for me on Ubuntu 14.04.
> It happens because pgrep gnome returns a PID of 
> /usr/bin/gnome-keyring-daemon at first position on my system
> User can't read /proc/$PID/environ due to its access rights:
> -r-------- 1 root root 0 Jul 16 16:41 /proc/0000/environ
>
> So I think that the DBUS_SESSION_BUS_ADDRESS determination should be 
> improved.
> I suggest to add check for DBUS_SESSION_BUS_ADDRESS and replace gnome 
> with gnome-session in pgrep call
> (it should be verified on all affected platforms).
Initially there was "gnome-session" in pgrep call, but Ubuntu 8.04 has 
no such process, so the test failed.
I've changed it to "pgrep gnome | head -1"
If we do not support ubuntu 8.04, I'll just replace "pgrep gnome" with 
"pgrep gnome-session".

So the question is, do we support Ubuntu 8.04?


Thanks,
Dima
> Thanks,
>
> Alexander.
> On 07/16/2014 03:09 PM, Dmitriy Ermashov wrote:
>> Hi,
>>
>> Just a kindly reminder. Please review the test:
>> http://cr.openjdk.java.net/~dermashov/8049694/webrev.00/
>>
>> Thanks,
>> Dima
>>
>> On 07/09/2014 01:29 PM, Dmitriy Ermashov wrote:
>>> Hi all,
>>>
>>> Please review yet another batch of tests. To be precise, just one test.
>>> http://cr.openjdk.java.net/~dermashov/8049694/webrev.00/
>>>
>>> The corresponding bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8049694
>>>
>>> This test verifies old RFE 4758438. It declares that AWT should 
>>> provide an access to XSETTINGS through the Toolkit.
>>> As you can see, the test consist of .java ans .sh files. The reason 
>>> for it is in different utilities for changing xsettings on different 
>>> OSes. E.g. old systems like Ubuntu 8.04 and Solaris 10 use 
>>> gconftool-2 utilily while Ubuntu 14.04 use gsettings.
>>> So the script decides which utility to use on current platform and 
>>> pass the parameters to java programm.
>>>
>>> The test passes on the following platforms:
>>> Solaris 10 sparcv9 (Java Desktop System)
>>> Solaris 11 x64 (Gnome 2)
>>> Ubuntu 8.04 virtualbox (Gnome 2)
>>> Ubuntu 10.04 arm (Gnome 2)
>>> Ubuntu 14.04 x64 (Unity)
>>>
>>> Windows 7 x64 (test just exit with 0 code)
>>> OS X 10.9 (test just exit with 0 code)
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140716/1d429fe2/attachment.html>