<AWT Dev> Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree
Petr Pchelko
petr.pchelko at oracle.com
Tue Jun 3 12:33:46 UTC 2014
Hello, Dmitriy.
I think that it worths adding -Xmx option to the GC tests as default max heap size is quite big.
Also could you please add @Override to the initGui method as now it's not obvious where is it called from.
Thank you.
With best regards. Petr.
On 03 июня 2014 г., at 15:21, Dmitriy Ermashov <dmitriy.ermashov at oracle.com> wrote:
> Hi all,
>
> Please review the last version of fix for
> https://bugs.openjdk.java.net/browse/JDK-8043131
>
> The webrev is here:
> http://cr.openjdk.java.net/~yan/8043131/webrev.01/
>
> Test colocation for remaining ShapedAndTranslucent part of functional tests.
> The fix also includes remarks for the first part of this batch. E.g. retrieved "@author mrkam" tag and full description for each test.
> GC tests also reverted as they are not similar to java/awt/Window/OwnedWindowsLeak/OwnedWindowsLeak.java and could be useful for finding bugs.
>
> Thanks,
> Dima
>
> On 05/19/2014 04:08 PM, Dmitriy Ermashov wrote:
>> Hi,
>>
>> Please review the changeset for bug:
>> https://bugs.openjdk.java.net/browse/JDK-8043131
>>
>> The webrev is here:
>> http://cr.openjdk.java.net/~yan/8043131/webrev.00/
>>
>> This is one more batch of functional AWT (ShapedAndTranslucentWindows and GC) tests are ought to be moved to regression tree.
>>
>
More information about the awt-dev
mailing list