<AWT Dev> [9] Review Request: JDK-8047798 Remove EventQueueDelegate

Petr Pchelko petr.pchelko at oracle.com
Mon Jun 23 18:03:12 UTC 2014


Hello, Anthony.

Thank you for the review.

> And I assume it also reverses JDK-6699328 ?
In a certain way. I’ve deleted all the code where that fix was made.

With best regards. Petr.

> On Jun 23, 2014, at 9:59 PM, Anthony Petrov <anthony.petrov at oracle.com> wrote:
> 
> The fix looks fine to me.
> 
>> this fix is a reverse-changeset for JDK-6638195
> 
> And I assume it also reverses JDK-6699328 ?
> 
> --
> best regards,
> Anthony
> 
> On 6/23/2014 6:40 PM, Petr Pchelko wrote:
>> Hello, Anthony.
>> 
>> Thank you for the review.
>> I've checked that this fix is a reverse-changeset for JDK-6638195 where the class was introduced.
>> 
>> With best regards. Petr.
>> 
>> On 23 июня 2014 г., at 18:32, Artem Ananiev <artem.ananiev at oracle.com> wrote:
>> 
>>> Hi, Petr,
>>> 
>>> the fix looks fine to me.
>>> 
>>> I would also suggest you to find the initial fix, when EventQueueDelegate was introduced (in 6u10?), to check if anything else can be wiped out.
>>> 
>>> Thanks,
>>> 
>>> Artem
>>> 
>>> On 6/23/2014 6:13 PM, Petr Pchelko wrote:
>>>> Hello, AWT Team.
>>>> 
>>>> Please review the fix for the issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-8047798
>>>> The fix is available at:
>>>> http://cr.openjdk.java.net/~pchelko/9/8047798/webrev/
>>>> 
>>>> One more weekly clenup. The EventQueueDelegate was added for JavaFXScript to manipulate EDT in unconventional ways.
>>>> Now it's not used and can be removed. Grepped the sources for the raminings and built a JPRT.
>>>> 
>>>> With best regards. Petr.
>>>> 
>> 



More information about the awt-dev mailing list