<AWT Dev> [9] Review Request: JDK-8047799 Remove WindowClosingSupport

Petr Pchelko petr.pchelko at oracle.com
Mon Jun 23 18:04:00 UTC 2014


Hello, Anthony.

> Out of curiosity, is the import BooleanSupplier statement in Dialog.java only needed to please the compiler when using "() -> true"? Does the code not compile w/o the import?
IDE has put it there for some reason. It’s not needed, I’ll remove it before the push.

With best regards. Petr.

> On Jun 23, 2014, at 9:50 PM, Anthony Petrov <anthony.petrov at oracle.com> wrote:
> 
> Looks fine.
> 
> Out of curiosity, is the import BooleanSupplier statement in Dialog.java only needed to please the compiler when using "() -> true"? Does the code not compile w/o the import?
> 
> --
> best regards,
> Anthony
> 
> On 6/23/2014 1:46 PM, Petr Pchelko wrote:
>> Hello, AWT Team.
>> 
>> Please review a weekly-cleanup fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8047799
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/9/8047799/webrev/
>> 
>> This feature was added for plugin in 1.4. I've grepped the sources and the interfaces and methods are not used any more.
>> I've run modality JTREG and checked the test for an original bug, everything seems to work fine. JPRT build succeeds.
>> 
>> With best regards. Petr.
>> 



More information about the awt-dev mailing list