<AWT Dev> [9] Review request for 8036598 [macosx] Create AquaIcons from image representations

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Mar 4 14:11:39 UTC 2014


Hi, Alexander.
I have only two suggestions about MultiResolutionBufferedImage
  - It could be final and its fields can be private final.
  - .toArray(length -> new Image[length])); can be replaced 
.toArray(Image[]::new));

On 3/4/14 5:32 PM, Alexander Scherbatiy wrote:
>
> Hello,
>
> Could you review the fix:
>   bug: https://bugs.openjdk.java.net/browse/JDK-8036598
>   webrev: http://cr.openjdk.java.net/~alexsch/8036598/webrev.00
>
>   The fix creates an AquaIcon based on resolution variants.
>   It becomes possible after the fix 8033534 where CImage returns
>   a MultiResolution image based on NSImage representations.
>
>
> Thanks,
> Alexandr.
>


-- 
Best regards, Sergey.



More information about the awt-dev mailing list