<AWT Dev> [9] Review Request: JDK-8036757 [macosx] Space menu accelerator not rendered correctly

[Anthony Petrov]

Yes, I agree. +1 on the fix.

--
best regards,
Anthony

On 3/6/2014 2:15 PM, Petr Pchelko wrote:
> Hello, Anthony.
>
>> The fix looks good technically. However, I'm not sure if allowing apps to use the Cmd-Space shortcut is a good idea because by default this key combination is used to either switch between keyboard layouts, or activate the SpotLight.
> If we want to prohibit the CMD+Space or Ctrl+Space we should do it way earlier. In this place the accelerator is already set and it would work anyway, just you would see nothing in the menu item (no character).
>
>> So I think this line has been commented out because of Human Interface Guidelines for OS X. I'm not 100% convinced we should change that.
> You could still use Alt+Space or even just space without any modifier (you could see these in iTunes control menu). Or more advanced combinations like
> Ctrl+Cmd+Space like in iTunes Edit menu.
>
> So I think we should render the Space symbol in the menu correctly anyway.
>
> With best regards. Petr.
>
> 06 марта 2014 г., в 2:07 после полудня, Anthony Petrov <anthony.petrov at oracle.com> написал(а):
>
>> Hi Petr,
>>
>> The fix looks good technically. However, I'm not sure if allowing apps to use the Cmd-Space shortcut is a good idea because by default this key combination is used to either switch between keyboard layouts, or activate the SpotLight. So I think this line has been commented out because of Human Interface Guidelines for OS X. I'm not 100% convinced we should change that.
>>
>> Are there other opinions? Mike, what do you think?
>>
>> --
>> best regards,
>> Anthony
>>
>> On 3/6/2014 1:00 PM, Petr Pchelko wrote:
>>> Hello, AWT Team.
>>>
>>> Please review a one-liner for:
>>> https://bugs.openjdk.java.net/browse/JDK-8036757
>>> The fix is available at:
>>> http://cr.openjdk.java.net/~pchelko/9/8036757/webrev/
>>>
>>> I supple this line was commented out because the code is not compilable with it) We should return a
>>> space character, it will be replaced with a proper ‘Space’ string internally by Cocoa. In case the app
>>> is bundled the string would even be localized. In non-bundled apps native localization does not work,
>>> but we can do nothing about it.
>>>
>>> With best regards. Petr.
>>>
>