<AWT Dev> [9] Review Request: JDK-8037560 [macosx] Cleaup CClipboard.m

[Anthony Petrov]

Sounds good. +1.

--
best regards,
Anthony

On 3/18/2014 1:39 PM, Petr Pchelko wrote:
> Hello, Anthony.
>
>> I didn't make a line-to-line comparison, but overall the new code looks good to me. Note that I'd leave the comment at old lines 176-179 as is for clarity.
> Ok, I'll return it back before the push.
>
>> PS. I assume all clipboard tests pass after this fix.
> Most of the tests fail on Mac OS X even before the fix because of the bug I've originally tried to fix, but this change does not add any new failures.
>
> With best regards. Petr.
>
> On 18.03.2014, at 13:30, Anthony Petrov <anthony.petrov at oracle.com> wrote:
>
>> Hi Petr,
>>
>> I didn't make a line-to-line comparison, but overall the new code looks good to me. Note that I'd leave the comment at old lines 176-179 as is for clarity.
>>
>> PS. I assume all clipboard tests pass after this fix.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 3/18/2014 12:17 PM, Petr Pchelko wrote:
>>> Hello, AWT Team.
>>>
>>> The bug: https://bugs.openjdk.java.net/browse/JDK-8037560
>>> The fix: http://cr.openjdk.java.net/~pchelko/9/8037560/webrev/
>>>
>>> Recently I've tried to fix our clipboard tests and make a proper implementation of the ClipboardOwner notifications on Mac OS X.
>>> However this appeared to be impossible without any over-complex solution due to Cocoa restrictions. By the way I've done a big
>>> clean-up of the Clipboard native code which would be a pity to throw away. So could you please review this clean-up fix.
>>>
>>> What I'm doing is replacing the selector-based invocations with block-based, so the source shrinks quite a lot.
>>>
>>> With best regards. Petr.
>>>
>>>
>