<AWT Dev> [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

[Anthony Petrov]

Hi Sergey,

Generally the fix looks good. I have only two concerns:

1. Previously we didn't exclude mirrored displays from the list. So the 
new code that you're adding at lines 84-92 might be better integrated as 
a separate fix.

2. Before the fix, the list of display devices returned from 
getDisplayIDs was in the same order as reported by the native system. 
After your fix the order is reversed. For instance, if previously the 
main display was always at index [0], not it's always at the tail of the 
array. This may or may not be a problem for Java applications (likely 
not a serious problem). However, keeping the same order between Java and 
native APIs might be a good thing for debugging purposes. Would it be 
possible to modify the loop at lines 103-106 to preserve the order?

--
best regards,
Anthony

On 3/19/2014 7:27 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 9.
> After the fix we use screen in sleep state as normal screen, where we
> can create new windows, etc.
> Disadvantage is that Robot still does not work on such devices.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-7124417
> Webrev can be found at: http://cr.openjdk.java.net/~serb/7124417/webrev.01
>