<AWT Dev> [9] Review request : 6788138 leak in Java_sun_awt_X11_XlibWrapper_getStringBytes?

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Mar 21 10:51:43 UTC 2014


Hi, Alexander.
A few notes.
  - documentation of this method is wrong.(copypaste from XFree)
  - This two line was added by the dm, in the fix for "Fixed size 
problem in getStringBytes" in 2003. Note that the storage has "length 
+1" size. Why?

On 3/21/14 2:27 PM, Alexander Zvegintsev wrote:
> Hello AWT team,
>
> please review the fix
> http://cr.openjdk.java.net/~azvegint/jdk/9/6788138/00/
> for the issue
> https://bugs.openjdk.java.net/browse/JDK-6788138
>
>
> Currently we use this function to get Window Manager name from native 
> only.
> It happens only once at startup, hence this leak is not noticeable.
>


-- 
Best regards, Sergey.



More information about the awt-dev mailing list