<AWT Dev> [9] Review request : 8030640 [TEST_BUG] java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh fails with exit code 2

Anthony Petrov anthony.petrov at oracle.com
Fri Mar 21 11:43:27 UTC 2014


Hi Konstantin,

/usr/libexec/java_home is an executable program (or script). You're 
assigning a path to this program to a variable that is supposed to hold 
a path to a JDK installation.

Could you please explain how you expect the above to work? What is the 
logic behind the change?

Also, how did you test your fix? I mean, surely, bash (or whatever shell 
is used) will now be happy with the syntax. But have you tried to 
actually make the bash and the test go through this case label and use 
the default JDK on the system?

--
best regards,
Anthony

On 3/21/2014 3:30 PM, Konstantin Shefov wrote:
> Hello AWT team,
>
> please review the fix
> http://cr.openjdk.java.net/~kshefov/8030640/webrev.00/
> for the issue
> https://bugs.openjdk.java.net/browse/JDK-8030640
>
> It is simple automatic test fix.
>
> Thanks
>
> -Konstantin


More information about the awt-dev mailing list