<AWT Dev> [9] Review request : 7161320 TEST_BUG: java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java fails (Invalid key code)

[Sergey Bylokhov]

Hi, Konstantin.
The fix looks good. Thanks.

On 3/21/14 4:59 PM, Petr Pchelko wrote:
> Thank you for checking this. I was not sure about meta on Linux.
>
> The fix looks good to me.
>
> With best regards. Petr.
>
> On 21.03.2014, at 16:51, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
>
>> Petr,
>>
>> This test works fine on Oracle Linux 6.4, Ubuntu Linux 12.10, OSX and Solaris 10.
>> On Windows it is skipped as expected.
>>
>> Konstantin
>>
>>
>> On 21.03.2014 16:53, Petr Pchelko wrote:
>>> Hello, Konstantin.
>>>
>>> Did you check that the test works fine on Linux?
>>>
>>> With best regards. Petr.
>>>
>>> On 21.03.2014, at 16:38, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
>>>
>>>> Hello AWT team,
>>>>
>>>> please review the fix
>>>> http://cr.openjdk.java.net/~kshefov/7161320/webrev.02/
>>>> for the issue
>>>> https://bugs.openjdk.java.net/browse/JDK-7161320
>>>>
>>>> It is simple automatic test fix. Windows is excluded from supported OS list for this test, because Windows does not support META key.
>>>>
>>>> Thanks
>>>>
>>>> -Konstantin


-- 
Best regards, Sergey.