<AWT Dev> [9] Review Request: JDK-8038106 PIT: access problem to a PrinterJob on OS X

Anthony Petrov anthony.petrov at oracle.com
Fri Mar 21 14:55:57 UTC 2014


+1

--
best regards,
Anthony

On 3/21/2014 6:36 PM, Sergey Bylokhov wrote:
> Hi, Petr.
> The fix looks good to me.
>
> On 3/21/14 6:28 PM, Petr Pchelko wrote:
>> Hello, AWT Team.
>>
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8038106
>> The fix is available here:
>> http://cr.openjdk.java.net/~pchelko/9/8038106/webrev/
>> <http://cr.openjdk.java.net/%7Epchelko/9/8038106/webrev/>
>>
>> Apparently I've made the class package-local and did not notice that
>> the class is being called by reflection.
>> I've checked other classes I've restricted access too, they should be
>> fine. I've also verified that KSS
>> would not complain if we mace the class public as it does not have
>> public native methods. The only
>> protected native method is fine as the class is final.
>>
>> With best regards. Petr.
>>
>>
>
>
> --
> Best regards, Sergey.
>


More information about the awt-dev mailing list