<AWT Dev> [9] Review Request: JDK-8038217 SunFontManager.initIDs NoSuchFieldError: lcdSubPixPos

[Petr Pchelko]

> Interesting. Do I understand correctly that the CHECK_NULL should have thrown an exception or otherwise report the error condition when it could not get the filed id?
It does throw the exception.

> Why wasn't this caught when testing the fix?
No idea. I'm not the author of an original fix.

With best regards. Petr.


On 24.03.2014, at 15:24, Anthony Petrov <anthony.petrov at oracle.com> wrote:

> Interesting. Do I understand correctly that the CHECK_NULL should have thrown an exception or otherwise report the error condition when it could not get the filed id? Why wasn't this caught when testing the fix?
> 
> The fix itself looks fine to me.
> 
> --
> best regards,
> Anthony
> 
> On 3/24/2014 3:24 PM, Petr Pchelko wrote:
>> Hello, AWT Team.
>> 
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8038217
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/9/8038217/webrev/
>> 
>> Simple typo in a parfait fix for JDK-8029008, prevents from testing code
>> on OS X.
>> 
>> With best regards. Petr.
>> 
>> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140324/d89e5e05/attachment-0001.html>