<AWT Dev> [9] Review request: 8041896 Test closed/java/awt/Choice/RemoveAllShrinkTest/RemoveAllShrinkTest fails with java.awt.IllegalComponentStateException

[Sergey Bylokhov]

Hi, Alexander.
The fix looks good to me as well.

On 5/13/14 3:20 PM, Petr Pchelko wrote:
> Hello, Alexander.
>
> The fix looks good to me.
>
> With best regards. Petr.
>
> On 12 мая 2014 г., at 19:44, Alexander Zvegintsev 
> <alexander.zvegintsev at oracle.com 
> <mailto:alexander.zvegintsev at oracle.com>> wrote:
>
>> Hello AWT team,
>>
>> please review the fix
>> http://cr.openjdk.java.net/~azvegint/jdk/9/8041896/00/
>> for the issue
>> https://bugs.openjdk.java.net/browse/JDK-8041896
>>
>> This test failure is a regression of the JDK-7159566 
>> <https://bugs.openjdk.java.net/browse/JDK-7159566> fix. We trying to 
>> call getLocationOnScreen() on a hidden popup.
>> We hide it if item count is 0 in AquaComboBoxPopup.show().
>> However, native Cocoa apps doesn't show a popup if it is empty at 
>> all, this fix do the same for java.
>>
>> With this fix RemoveAllShrinkTest test moved to open.
>> -- 
>> Thanks,
>>
>> Alexander.
>


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140513/08b9a082/attachment-0001.html>