<AWT Dev> [9] Request for Review: 8003900: X11 dependencies should be removed from Mac OS X build.
David DeHaven
david.dehaven at oracle.com
Tue May 13 16:11:34 UTC 2014
>> Hi David,
>>
>> The fix looks good to me. To answer your questions:
>>
>> 1. Using the XAWT macro is correct. It is only defined if we're building
>> the XToolkit, which we don't on the Mac. However, everywhere else we
>> actually check
>
> XAWT is a legacy macro, which was introduced to share code between XToolkit and MToolkit on Linux/Solaris. At the moment, XAWT is always defined on Linux/Solaris and never defined on Mac OS X, so checks against XAWT and MACOSX are interchangeable. In the future, if we support anything besides X11 on Linux/Solaris, XAWT may be of some use again, but MACOSX meaning is unlikely to change. So my preference would be to use MACOSX rather than !XAWT.
Ok, I'll update the webrev.
-DrD-
More information about the awt-dev
mailing list