<AWT Dev> [9] Request for Review: 8003900: X11 dependencies should be removed from Mac OS X build.
David DeHaven
david.dehaven at oracle.com
Fri May 16 13:50:19 UTC 2014
Thanks Petr!
-DrD-
Sent from my iPhone
> On May 16, 2014, at 1:23 AM, Petr Pchelko <petr.pchelko at oracle.com> wrote:
>
> Hello, David.
>
> I've pushed your fix to the client repo:
> http://hg.openjdk.java.net/jdk9/client/jdk/rev/56024e323104
>
> With best regards. Petr.
>
>> On 16 мая 2014 г., at 11:57, Artem Ananiev <artem.ananiev at oracle.com> wrote:
>>
>>
>> I'm fine with the fix.
>>
>> Thanks,
>>
>> Artem
>>
>>> On 5/15/2014 9:36 PM, Petr Pchelko wrote:
>>> Hello, David.
>>>
>>> The fix looks good to me.
>>> Artem was interested in the review, so we may want to wait for his final vote..
>>>
>>> I can push the changeset for you. Please ping me when you decide it’s ready to go.
>>>
>>> Thank you.
>>> With best regards. Petr.
>>>
>>>> On May 15, 2014, at 8:23 PM, David DeHaven <david.dehaven at oracle.com> wrote:
>>>>
>>>>
>>>> Can I get another reviewer on this? I need a sponsor to push too.. (Anthony?)
>>>>
>>>> -DrD-
>>>>
>>>>>
>>>>>> src/solaris/native/sun/awt/awt.h
>>>>>>> 113 #if !defined(HEADLESS) && defined(XAWT)
>>>>>>> 114 extern Display *awt_display; /* awt_GraphicsEnv.c */
>>>>>>
>>>>>> You forgot to update this XAWT usage. Otherwise the fix looks fine.
>>>>>
>>>>> Whoops! Updated in-place.
>>>>>
>>>>> -DrD-
>
More information about the awt-dev
mailing list