<AWT Dev> [9] Review request for 8036110 In TextField can only select text visible or to the left of the cursor

[Petr Pchelko]

Hello, Alexander.

Looks good to me too.

With best regards. Petr.

On May 20, 2014, at 4:25 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:

> Hi, Alexander.
> The fix looks fine.
> 
> On 5/20/14 4:22 PM, Alexander Scherbatiy wrote:
>> On 5/19/2014 8:18 PM, Sergey Bylokhov wrote:
>>> Hello, Alexander.
>>> Can you check that the test works correctly on linux/osx.
>> 
>>   The test passes on Linux Ubuntu and Mac OS X.
>> 
>>   Thanks,
>>   Alexandr.
>> 
>>> 
>>> On 19.05.2014 19:05, Alexander Scherbatiy wrote:
>>>> 
>>>> Hello,
>>>> 
>>>> Could you review the fix:
>>>>  bug: https://bugs.openjdk.java.net/browse/JDK-8036110
>>>>  webrev: http://cr.openjdk.java.net/~alexsch/8036110/webrev.00
>>>> 
>>>>  This is a regression from the fix 7092551 where the EDIT control has been changed to the RICHEDIT.
>>>>  GetScrollInfo(hWnd, SB_HORZ, &scrollinfo) returns zero values for the RICHEDIT if WS_HSCROLL style is not set.
>>>> 
>>>>  The fix enables the horizontal scrollbar before the GetScrollInfo call and disbles it after the call.
>>>> 
>>>> Thanks,
>>>> Alexandr.
>>>> 
>>> 
>>> 
>> 
> 
> 
> -- 
> Best regards, Sergey.
>