<AWT Dev> [7u-dev] Review request for 8015500: Prevent sending multiple WINDOW_CLOSED events for already disposed windows
Anton Litvinov
anton.litvinov at oracle.com
Tue May 20 15:21:19 UTC 2014
Hello Sergey and Anthony,
Thank you for a response to this review request and for provision of
such important details concerning the original fix. In such case I do
not see any necessity to port this fix to JDK 7 anymore, since it became
known that this fix caused:
- failure of JCK test
- modification of the failing JCK test
- creation of the fix for JDK-8020851 requiring CCC request.
This backport was necessary to resolve the duplicate bug
(https://bugs.openjdk.java.net/browse/JDK-8041692) with P3 priority.
Thank you,
Anton
On 5/20/2014 6:41 PM, Anthony Petrov wrote:
> Indeed. Thanks for the reminder, Sergey. In that case Anton should
> discuss this issue with the JCK team before proceeding.
>
> --
> best regards,
> Anthony
>
> On 5/20/2014 6:39 PM, Sergey Bylokhov wrote:
>> On 5/20/14 6:37 PM, Anthony Petrov wrote:
>>> Hi Anton,
>>>
>>> If the fix is identical, then you don't need another technical review.
>>> I'm fine with porting the fix to JDK 7u.
>> This is not the case. This fix caused a jck failure and ccc request see
>> 8020851.
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
>>> On 5/20/2014 6:20 PM, Anton Litvinov wrote:
>>>> Hello Anthony and Sergey,
>>>>
>>>> Could you please review this backport of the fix , which was reviewed
>>>> and approved by you for JDK 8, from JDK 8 to JDK 7. The backport
>>>> fix is
>>>> identical to the original fix. The original fix was reviewed at this
>>>> e-mail alias under the subject "[PATCH] 7168064:
>>>> SwingUtilities.sharedOwnerFrame multiplies window close event" in
>>>> 2013.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8015500
>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8015500/jdk7/webrev.00
>>>> JDK 8 webrev:
>>>> http://cr.openjdk.java.net/~anthony/8-59-windowClosedEvents-8015500.1
>>>>
>>>> Thank you,
>>>> Anton
>>
>>
More information about the awt-dev
mailing list