<AWT Dev> [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Edward Burns edward.burns at oracle.com
Fri May 23 16:50:16 UTC 2014


>>>>> On Fri, 23 May 2014 19:14:24 +0400, anton nashatyrev <anton.nashatyrev at oracle.com> said:

AN> Hello,
AN>      could you please review the following fix:

AN> fix: http://cr.openjdk.java.net/~anashaty/8028617/9/webrev.00/ 
AN> <http://cr.openjdk.java.net/%7Eanashaty/8028617/9/webrev.00/>
AN> bug: https://bugs.openjdk.java.net/browse/JDK-8028617

AN>      Problem: Dvorak keyboard mapping not honored when Ctrl key pressed

AN>      Evaluation:
AN>          The problem is in the AWTView.m:deliverJavaKeyEventHelper(): 
AN> for taking a character we use NSEvent::characters which works fine until 
AN> the Ctrl modifier is pressed. In this case the 'charaters' returns empty 
AN> string. The typed character is then calculated via key code using the 
AN> standard keyboard layout. Of course that doesn't work for any other 
AN> layout including DVORAK.

AN>      Fix: We should use NSEvent::charactersIgnoringModifiers property 
AN> instead (especially taking into account that 
AN> sun.lwawt.macosx.event.NSEvent constructor parameter name is 
AN> 'charactersIgnoringModifiers')

Thank you so much for doing this.  This bug makes it hard for DVORAK
users to use JDK7 for desktop apps such as NetBeans.  How can I advocate
for having it fixed in JDK7 and JDK8 and not have to wait for JDK9?

Thanks,

Ed

-- 
| edward.burns at oracle.com | office: +1 407 458 0017


More information about the awt-dev mailing list