<AWT Dev> Review Request for 8041915: Move 8 awt tests to OpenJDK regression tests tree

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon May 26 12:04:41 UTC 2014


Hi, Dmitriy.
One of the test has incorrect copyright:

   23 /*
   24  * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
   25  * ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license terms.
   26  */

I was thinking that the author of these tests is Alexander Kouznetsov, no?

On 26.05.2014 14:36, Dmitriy Ermashov wrote:
> Thanks for review!
> -dima
>
> On 05/26/2014 02:21 PM, Alexander Scherbatiy wrote:
>>
>>   The fix looks good for me.
>>
>>   Thanks,
>>   Alexandr.
>>
>> On 5/26/2014 1:41 PM, Dmitriy Ermashov wrote:
>>> Hi,
>>>
>>> I still have no second successful review..
>>> Could you please look at the fix of
>>> https://bugs.openjdk.java.net/browse/JDK-8041915
>>>
>>> Webrev is here:
>>> http://cr.openjdk.java.net/~yan/8041915/webrev.01/
>>>
>>> It is a part of test colocation.
>>>
>>> Thanks,
>>> Dima
>>>
>>> On 05/12/2014 03:16 PM, Dmitriy Ermashov wrote:
>>>> Petr, thanks for review.
>>>>
>>>> Guys, could you please also review the changeset?
>>>> Webrev is here:
>>>> http://cr.openjdk.java.net/~yan/8041915/webrev.01/
>>>>
>>>> Thanks,
>>>> Dima
>>>>
>>>> On 29.04.2014 15:08, Petr Pchelko wrote:
>>>>> Hello, Dmitriy.
>>>>>
>>>>> The new version looks good.
>>>>>
>>>>> With best regards. Petr.
>>>>>
>>>>> On 29.04.2014, at 14:49, Dmitriy Ermashov 
>>>>> <dmitriy.ermashov at oracle.com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please review the changeset for
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8041915
>>>>>>
>>>>>> Webrev is here:
>>>>>> http://cr.openjdk.java.net/~yan/8041915/webrev.01/
>>>>>>
>>>>>> Latest changes:
>>>>>> 1. If some translucency mode is not supported, the test will pass 
>>>>>> with System.out warning message
>>>>>> 2. New method dragAndDrop implemented in ExtendedRobot class
>>>>>>
>>>>>> Thanks,
>>>>>> Dima
>>>>>>
>>>>>> On 04/25/2014 05:19 PM, Petr Pchelko wrote:
>>>>>>> Hello, Dmitriy.
>>>>>>>
>>>>>>> A couple of questions:
>>>>>>>
>>>>>>> 1. checkTranslucencyMode throws an exception if some mode is not 
>>>>>>> supported on the device, so the test would fail. Should it? 
>>>>>>> Normally we just skip the test if some capability is absent.
>>>>>>> 2. Didn't you consider moving the drag method into the 
>>>>>>> ExtendedRobot? I expect it to be very commonly used.
>>>>>>>
>>>>>>> With best regards. Petr.
>>>>>>>
>>>>>>> On 25.04.2014, at 17:04, Dmitriy Ermashov 
>>>>>>> <dmitriy.ermashov at oracle.com> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Please review the changeset for
>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8041915
>>>>>>>>
>>>>>>>> Webrev is here:
>>>>>>>> http://cr.openjdk.java.net/~yan/8041915/webrev.00/
>>>>>>>>
>>>>>>>> -- 
>>>>>>>> Thanks,
>>>>>>>> Dima
>>>>>>>>
>>>>
>>>
>>
>


-- 
Best regards, Sergey.



More information about the awt-dev mailing list