<AWT Dev> [9] Review request for 8044172: Move regtests for 4523758 and AltPlusNumberKeyCombinationsTest to jdk

Petr Pchelko petr.pchelko at oracle.com
Thu May 29 14:19:53 UTC 2014


Hello, Yuri.

The updated version look good to me.

With best regards. Petr.

On 29 мая 2014 г., at 18:03, Yuri Nesterenko <yuri.nesterenko at oracle.com> wrote:

> Oops! Thank you Petr,
> 
> here's an updated version with RuntimeException instead of exit():
> 
> http://cr.openjdk.java.net/~yan/8044172/webrev.01
> 
> Link to the bug, for consistency,
> https://bugs.openjdk.java.net/browse/JDK-8044172
> 
> Regards,
> -yan
> 
> On 05/28/2014 10:18 PM, Petr Pchelko wrote:
>> Hello, Yuri.
>> 
>> The bug4523758 test contains System.exit. Could you please replace it with throwing an exception?
>> Otherwise the fix looks good.
>> 
>> With best regards. Petr.
>> 
>> On May 28, 2014, at 7:34 PM, Yuri Nesterenko <yuri.nesterenko at oracle.com> wrote:
>> 
>>> Hi,
>>> 
>>> yet another small batch of 2 tests to move from functional suite to jdk
>>> 
>>> Bug is
>>> https://bugs.openjdk.java.net/browse/JDK-8044172
>>> 
>>> and webrev
>>> http://cr.openjdk.java.net/~yan/8044172/webrev.00
>>> 
>>> Thanks!
>>> -yan
>>> 
>> 
> 



More information about the awt-dev mailing list