<AWT Dev> [9] Review request for 8032788: ImageIcon constructor throws an NPE and hangs when passed a null String parameter

[Sergey Bylokhov]

Hi, Anton.
The fix looks good. But can you rename the test to some useful name like 
other tests in java/awt/image?

On 5/29/14 9:11 PM, anton nashatyrev wrote:
> Hello,
>
>     any volunteers to review please? The fix is pretty simple.
>
> http://cr.openjdk.java.net/%7Eanashaty/8032788/9/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8032788
>
> Thanks!
> Anton.
>
> On 22.05.2014 22:29, anton nashatyrev wrote:
>> Hello,
>>     could you please review the following fix:
>>
>> fix: http://cr.openjdk.java.net/~anashaty/8032788/9/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Eanashaty/8032788/9/webrev.00/>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8032788
>>
>>     Problem: MediaTracker.waitForID() hangs if the Image was created 
>> with null argument.
>>       The expected behavior is the same as if the non-existent file 
>> name is passed, i.e. ERRORED loading status
>>
>>     Fix: avoid throwing unexpected NPE from FileImageSource.getDecoder()
>>
>> Thanks!
>> Anton.
>


-- 
Best regards, Sergey.