<AWT Dev> [9] Review Request for JDK-8004148: NPE in sun.awt.SunToolkit.getWindowDeactivationTime
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Mon Nov 10 12:20:56 UTC 2014
Hi, Anton.
The fix looks good.
On 07.11.2014 17:13, Anton V. Tarasov wrote:
> Hello,
>
> Please, review the fix.
>
> https://bugs.openjdk.java.net/browse/JDK-8004148
> http://cr.openjdk.java.net/~ant/JDK-8004148/webrev.0
>
> There's no a test case for the original issue. However, there's
> another test case which reproduces NPE with the same stack trace. The
> problem was fixed in jdk8 in JDK-8001633.
>
> However, I suggest to do a sanity check for null. I check for null
> AppContext which covers the case for null Window as well.
>
> Thanks,
> Anton.
>
>
--
Best regards, Sergey.
More information about the awt-dev
mailing list