<AWT Dev> [9] Review Request for 8055836: move awt tests from AWT_Modality to OpenJDK repository - part 9

Petr Pchelko petr.pchelko at oracle.com
Mon Nov 10 13:26:19 UTC 2014


Hello, Alexander.

The fix looks fine.

With best regards. Petr.

On 27 окт. 2014 г., at 14:24, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:

> Hello,
> 
> Could please anyone review this old request?
> 
> Thanks,
> Alexander
> 
> On 24.09.2014 17:08, alexander stepanov wrote:
>> Hello Sergey,
>> 
>> Thanks, fixed:
>> http://cr.openjdk.java.net/~avstepan/8055836/webrev.01/
>> 
>> Regards,
>> Alexander
>> 
>> On 23.09.2014 18:58, Sergey Bylokhov wrote:
>>> Hi, Alexander.
>>> PrintDialogsTest: fields are assigned on one thread in the start(), and used on EDT in actionPerformed()..
>>> 
>>> On 19.09.2014 17:13, alexander stepanov wrote:
>>>> Hello,
>>>> 
>>>> Could you please review the fix for
>>>> https://bugs.openjdk.java.net/browse/JDK-8055836
>>>> 
>>>> webrev:
>>>> http://cr.openjdk.java.net/~avstepan/8055836/
>>>> 
>>>> This is the result of refactoring for corresponding portion of functional AWT tests.
>>>> 
>>>> The test was checked on Windows 7, Solaris 11, Mac OS X 10.8.5 and Ubuntu 12.04 Linux.
>>>> 
>>>> Thanks,
>>>> Alexander
>>> 
>>> 
>> 
> 



More information about the awt-dev mailing list