<AWT Dev> [9] Review Request for 8054359: move awt automated tests from AWT_Modality to OpenJDK repository - part 8

alexander stepanov alexander.v.stepanov at oracle.com
Fri Nov 14 10:39:20 UTC 2014


Hello Petr,

Thanks!

Regards,
Alexander

On 14.11.2014 12:47, Petr Pchelko wrote:
> Hello, Alexander.
>
> The fix looks good to me.
>
> With best regards. Petr.
>
> On 27 окт. 2014 г., at 14:25, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:
>
>> Hello,
>>
>> Could please anyone review this old request?
>>
>> Thanks,
>> Alexander
>>
>> On 25.09.2014 17:08, alexander stepanov wrote:
>>> Sorry, just a reminder.
>>>
>>> Thanks,
>>> Alexander
>>>
>>> On 12.09.2014 15:08, alexander stepanov wrote:
>>>> Hello Alexandr,
>>>>
>>>> Fixed; please see the updated webrev:
>>>> http://cr.openjdk.java.net/~avstepan/8054359/webrev.01/
>>>>
>>>> Thanks,
>>>> Alexander
>>>>
>>>> On 12.09.2014 12:49, Alexander Scherbatiy wrote:
>>>>>   75         int x = Toolkit.getDefaultToolkit().getScreenSize().width - 200;
>>>>>   76         parent.setLocation(x, 50);
>>>>>   77         window.setLocation(x, 250);
>>>>>   78         dialog.setLocation(x, 450);
>>>>>
>>>>> It is better to use part of the screen or frame size instead of absolute values like 200, 50 and 450.
>>>>>
>>>>> Thanks,
>>>>> Alexandr.
>>>>>
>>>>> On 9/11/2014 6:31 PM, alexander stepanov wrote:
>>>>>> Sorry, just a reminder. Could anyone please review that?
>>>>>>
>>>>>> Thanks,
>>>>>> Alexander
>>>>>>
>>>>>>
>>>>>> On 22.08.2014 20:17, alexander stepanov wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> Could you please review the fix for
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8054359
>>>>>>>
>>>>>>> webrev:
>>>>>>> http://cr.openjdk.java.net/~avstepan/8054359/
>>>>>>>
>>>>>>> This is the next portion of functional AWT tests prepared for migration to OpenJDK repository.
>>>>>>>
>>>>>>> The tests were checked on Ubuntu 14.04 Linux, Solaris 11 and Windows 7.
>>>>>>>
>>>>>>> On Mac OS X 10.8.5 they are failing due to unfixed
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-7186009
>>>>>>>
>>>>>>> Some of them are also failing because of
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8055752
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Alexander



More information about the awt-dev mailing list