<AWT Dev> [9] Review request: JDK-8058193 [macosx] Potential incomplete fix for JDK-8031485

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Nov 19 12:26:08 UTC 2014


Hi, Petr.
The fix looks fine. But please update a @bug tag, test name and error 
message in the test as well before the push.

On 19.11.2014 14:19, Petr Pchelko wrote:
> Hello, AWT Team.
>
> Please review the fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-8058193
> The fix is available at:
> http://cr.openjdk.java.net/~pchelko/9/8058193/webrev/
>
> The problem is that we consume Enter key by a combo box action and it's not propagated up to the dialog.
> Enter does not trigger any real action on the closed ComboBox, so it should be disabled if the combo popup
> is not visible.
>
> With best regards. Petr.


-- 
Best regards, Sergey.



More information about the awt-dev mailing list