<AWT Dev> [9] Review request for JDK-8059590: ArrayIndexOutOfBoundsException occurs when Container with overridden getComponents() is deserialized

[Sergey Bylokhov]

Thanks!

On 17.10.2014 13:03, Alexey Ivanov wrote:
> Hi Sergey,
>
> Thank you for your review.
> I've rename the test to ContainerAIOOBE.
>
> Updated webrev: 
> http://cr.openjdk.java.net/~aivanov/8059590/jdk9/webrev.01/
>
> Thanks,
> Alexey.
>
> On 16.10.2014 17:47, Sergey Bylokhov wrote:
>> Hi, Alexey.
>> The fix looks good, but please rename the test to some useful name.
>>
>> On 16.10.2014 17:21, Alexey Ivanov wrote:
>>> Hello AWT Team,
>>>
>>> Could you please review the fix for the bug:
>>>     bug: https://bugs.openjdk.java.net/browse/JDK-8059590
>>>     webrev: http://cr.openjdk.java.net/~aivanov/8059590/jdk9/webrev.00/
>>>
>>> Problem description:
>>> If one overrides getComponents() method of java.awt.Container to 
>>> return an array of different size than the number of components in 
>>> Container, ArrayIndexOutOfBoundsException could be thrown during 
>>> deserialization. Container.writeObject() stores the number of 
>>> components by accessing its list directly but stores the array of 
>>> components that's returned by overridden getComponents() method.
>>>
>>> Thank you in advance,
>>> Alexey.
>>
>>
>


-- 
Best regards, Sergey.