<AWT Dev> [9] Review request for JDK-8056211: JCK test api/java_awt/Event/InputMethodEvent/serial fails

[Alexey Ivanov]

Petr, Alexander,

Thank you for your review.

Regards,
Alexey.

On 02.09.2014 15:47, Alexander Zvegintsev wrote:
> Hello Alexey,
>
> the fix looks good to me too.
>
> Thanks,
>
> Alexander.
>
> On 09/02/2014 03:31 PM, Petr Pchelko wrote:
>> Hello, Alexey.
>>
>> The fix looks good to me.
>>
>> With best regards. Petr.
>>
>>> On Sep 2, 2014, at 3:09 PM, Alexey Ivanov <alexey.ivanov at oracle.com> 
>>> wrote:
>>>
>>> Hello AWT team,
>>>
>>> This is a reminder,
>>>
>>> Is there any volunteer to review this fix?
>>>
>>> Thanks,
>>> Alexey.
>>>
>>> On 29.08.2014 12:20, Alexey Ivanov wrote:
>>>> Hello AWT Team,
>>>>
>>>> Could you please review the fix for bug:
>>>>     bug: https://bugs.openjdk.java.net/browse/JDK-8056211
>>>>     webrev: 
>>>> http://cr.openjdk.java.net/~aivanov/8056211/jdk9/webrev.00/
>>>>
>>>> Description:
>>>> When you deserialize InputMethodEvent object serialized with JDK 
>>>> 1.3 or earlier, you'll get java.lang.IllegalArgumentException: null 
>>>> source. To initialize 'when' field, getMostRecentEventTimeForSource 
>>>> is used in this case but 'source' field is always null when object 
>>>> is deserialized.
>>>>
>>>> The fix:
>>>> Use the old way to initialize 'when' field where its value is 0, 
>>>> that is EventQueue.getMostRecentEventTime().
>>>>
>>>>
>>>> Thank you in advance,
>>>> Alexey.
>