<AWT Dev> The path to flavormap.properties is currently broken in SystemFlavorMap

[Ludovic HOCHET]

Hello Alexander,
Thanks for the additional explanation.
Good to see the datatransfer API becoming autonomous.

Best Regards,
Ludovic

On Tue, Sep 2, 2014 at 5:13 PM, Alexander Zvegintsev
<alexander.zvegintsev at oracle.com> wrote:
> Hello Ludovic,
>
> Addition of "resources" is widely used at least in the OpenJDK project.
> You can easily check it by finding "*.properties" files over sources
> directory.
>
> As for flavormap.properties files movement in general: JDK-8051449 [1] is
> one of the transitional steps to
> separate java.awt.datatransfer from the desktop module [2]. You can find
> more info about this in the issue description.
>
>
>
> [1]https://bugs.openjdk.java.net/browse/JDK-8051449  Incorrect parsing of
> the default flavor mapping
> [2]https://bugs.openjdk.java.net/browse/JDK-8056298  Separate
> java.awt.datatransfer from the desktop module
>
> Thanks,
>
> Alexander.
>
>
> On 09/01/2014 11:56 PM, Ludovic HOCHET wrote:
>>
>> Hello Alexander,
>> Thanks for the links, I get now the reason for the start of the
>> package name, is the addition of "resources" standard practice? (just
>> wondering).
>>
>> Best Regards,
>> Ludovic
>>
>> On Mon, Sep 1, 2014 at 9:12 PM, Alexander Zvegintsev
>> <alexander.zvegintsev at oracle.com> wrote:
>>>
>>> Hello Ludovic,
>>>
>>> Your fix solves the issue, but flavormap.properties files movement is
>>> part
>>> of the JDK-8051449 fix [1] which was lost during the merge.
>>> Reason of this movement is mentioned in the JDK-8051449 review thread
>>> [2]:
>>>
>>> On 7/28/14 3:35 PM, Petr Pchelko wrote:
>>>>
>>>> ...
>>>> I've changed the package name for a flavormap.properties file, because
>>>> it
>>>> needs to go to the
>>>
>>> datatransfer module and in a parallel review we've decided to change it's
>>> package name.
>>>>
>>>> ...
>>>
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8051449 Incorrect parsing of
>>> the default flavor mapping
>>> [2] http://mail.openjdk.java.net/pipermail/awt-dev/2014-July/008318.html
>>>
>>> --
>>> Thanks,
>>> Alexander.
>>>
>>>
>>> 01.09.2014 22:46, Ludovic HOCHET wrote:
>>>>
>>>> JDK-8055746 describes the exception I was having.
>>>> The cr that was posted is the other solution I thought for the issue,
>>>> however as it was unclear for me why the path should be
>>>> sun/datatransfer/**resources**/flavormap.properties, I went with the
>>>> solution I posted.
>>>>
>>>>
>>>> --
>>>> Ludovic
>>>>
>>>> On Mon, Sep 1, 2014 at 10:29 AM, Yuri Nesterenko
>>>> <yuri.nesterenko at oracle.com> wrote:
>>>>>
>>>>> On 09/01/2014 12:24 PM, Alan Bateman wrote:
>>>>>>
>>>>>>
>>>>>> This does seem to a merge issue.
>>>>>>
>>>>>> When the source reorganization was pushed to jdk9/jdk9 (and
>>>>>> immediately
>>>>>> to jdk9/dev) then the resource was in sun/datatransfer.
>>>>>>
>>>>>> Soon afterwards there was an integration + merge from jdk9/client ->
>>>>>> jdk9/dev that brought this change:
>>>>>>       http://hg.openjdk.java.net/jdk9/client/jdk/rev/e4724b19c64b
>>>>>>
>>>>>> that moved it to sun/datatransfer/resources. Unfortunately the merged
>>>>>> bits aren't quite right as you have found.
>>>>>>
>>>>>> Has there been a bug created for this?
>>>>>>
>>>>>> -Alan.
>>>>>
>>>>>
>>>>> Sure, https://bugs.openjdk.java.net/browse/JDK-8055746
>>>>> in the PIT time of jdk9/client just after jigsaw refactoring.
>>>>>
>>>>> -yan
>>>>
>>>>
>>>>
>>
>>
>



-- 
Ludovic
-----------------------------------------

"Les formes qui differencient les etres importent peu
 si leur pensees s'unissent pour batir un univers..."
 Yoko Tsuno (in 'Les titans' by Roger Leloup)
 [The shapes that differenciate beings are not important
 if their thoughts unite to build a universe]