<AWT Dev> [9] Review request for 8058473: "Comparison method violates its general contract" when using Clipboard

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Sep 18 13:30:00 UTC 2014


Hi, Anton.
The fix looks good overall, but a few notes:
  - Can you try to change sort TimSort algorithm  to mergerSort. What 
the order will be in this case ?(see JDK-8048887).
  - Can you run all related regression and jck tests.
Thanks.

On 18.09.2014 17:04, anton nashatyrev wrote:
> Hello,
>     could you please review the following fix:
>
> fix: http://cr.openjdk.java.net/~anashaty/8058473/9/webrev.00/ 
> <http://cr.openjdk.java.net/%7Eanashaty/8058473/9/webrev.00/>
> bug: https://bugs.openjdk.java.net/browse/JDK-8058473
>
>     Problem: DataFlavorComparator violates Comparator contract.
>
>     Fix: make the DataFlavorComparator transitive conformant (please 
> see the bug comment for details)
>
> Thanks!
> Anton.


-- 
Best regards, Sergey.



More information about the awt-dev mailing list