<AWT Dev> [9] Review request for 8078165: [macosx] NPE when attempting to get image from toolkit
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Thu Apr 23 13:14:25 UTC 2015
Hi, Anton.
The fix looks good.
On 23.04.15 14:12, Anton Nashatyrev wrote:
> Hi Sergey,
>
> thanks for catching that! Was a little bit in a hurry to fix this
>
> Here is the updated fix
> http://cr.openjdk.java.net/~anashaty/8078165/webrev.01/
> <http://cr.openjdk.java.net/%7Eanashaty/8078165/webrev.01/>
>
> Thanks!
> Anton.
>
> On 22.04.2015 22:40, Sergey Bylokhov wrote:
>> Hi, Anton.
>> It seems both methods can be simplified because both already have
>> such checks?
>>
>> On 22.04.15 22:12, Anton Nashatyrev wrote:
>>> Hello,
>>> could you please review the following simple fix:
>>>
>>> fix: http://cr.openjdk.java.net/~anashaty/8078165/webrev.00/
>>> <http://cr.openjdk.java.net/%7Eanashaty/8078165/webrev.00/>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8078165
>>>
>>> Problem: on MacOS Toolkit.getImage() throws NPE under some
>>> circumstances when LWCToolkit.getScaledImageName() returns null.
>>>
>>> Fix: check for null
>>>
>>> Thanks!
>>> Anton.
>>
>>
>
--
Best regards, Sergey.
More information about the awt-dev
mailing list