<AWT Dev> <Awt Dev> [9] Review Request for 8130471: [Regression] Test java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Extra.java fails

[Semyon Sadetsky]

On 7/29/2015 2:06 PM, Alexander Scherbatiy wrote:
> On 7/23/2015 9:21 PM, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8130471
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8130471/webrev.00/
>
>    The initial name of the boolean variable in the getModifiers(...) 
> method was wheel_mouse. Could you use name like isWheelMouse instead 
> of the inverted one?
>
http://cr.openjdk.java.net/~ssadetsky/8130471/webrev.01/

--Semyon
> Thanks,
>   Alexandr.
>>
>> This is a regression from 8041470 in which mouse event modifiers was 
>> changed for all wheel events including button click event. That 
>> caused wrong modifiers for buttons 4 and 5 press/release/click mouse 
>> events. The solution is to restore modifiers for click events keeping 
>> 8041470 changes for scroll events.
>>
>> --Semyon
>