<AWT Dev> [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

[Alexander Scherbatiy]

The fix looks good to me.

Thanks,
Alexandr.

On 8/25/2015 3:56 PM, Renjith Alexander wrote:
> Hi Alexander,
>
> Formatted the code accordingly. Please find the diffs:
>
> http://cr.openjdk.java.net/~pchopra/8132376/webrev.05/
> http://cr.openjdk.java.net/~pchopra/8132376/webrev.06/
>
> Regards,
> Renjith.
>
> -----Original Message-----
> From: Alexander Scherbatiy
> Sent: Tuesday, August 25, 2015 2:46 PM
> To: Renjith Alexander
> Cc: awt-dev at openjdk.java.net
> Subject: Re: <AWT Dev> [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API
>
> On 8/24/2015 12:27 PM, Renjith Alexander wrote:
>> Hi All,
>>
>> Please review the updated diff for Bug JDK-8132376.
>>
>> Webrev: http://cr.openjdk.java.net/~pchopra/8132376/webrev.03/
>>
>> To see the diff between the versions of files, which are moved from closed repository to open, see webrev:
>>
>> http://cr.openjdk.java.net/~pchopra/8132376/webrev.04/
>      The code should be properly formatted. There are a lot of places long indentation or extra spaces in the 'if' block or before '{' brackets.
>      All lines which are longer than 80 characters should be split.
>
>     Thanks,
>     Alexandr.
>>
>> Regards,
>> Renjith.
>>
>> -----Original Message-----
>> From: Alexander Scherbatiy
>> Sent: Thursday, August 20, 2015 7:53 PM
>> To: Renjith Alexander
>> Cc: awt-dev at openjdk.java.net
>> Subject: Re: <AWT Dev> [awt-dev] Request for Approval and Review:
>> JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests
>> with access to internal OS-specific API
>>
>> On 8/18/2015 9:02 AM, Renjith Alexander wrote:
>>> Hi All,
>>>
>>> Please review the updated fix for Bug JDK-8132376:
>>>
>>> Webrev: http://cr.openjdk.java.net/~sgupta/8132376/webrev.03/
>>       - Please, remove all "Standard Test Machinery Section" which is not really used in the test.
>>         The test only uses DisplayChangedTest.pass() and
>> DisplayChangedTest.fail() which can be just replaced
>>         by throwing an exception for the fail case.
>>      - remove all System.out.println()
>>      - split lines if they longer than 80 characters
>>
>>      Thanks,
>>      Alexandr.
>>
>>> The Webrev for diff between files in closed(which are moved to open in the above webrev):
>>>
>>> http://cr.openjdk.java.net/~sgupta/8132376/webrev.02/
>>>
>>> Regards,
>>> Renjith.
>>>
>>>
>>>
>>> -----Original Message-----
>>> From: Alexander Scherbatiy
>>> Sent: Monday, August 10, 2015 7:24 PM
>>> To: Renjith Alexander
>>> Cc: awt-dev at openjdk.java.net
>>> Subject: Re: <AWT Dev> [awt-dev] Request for Approval and Review:
>>> JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests
>>> with access to internal OS-specific API
>>>
>>> On 8/7/2015 1:56 PM, Renjith Alexander wrote:
>>>> Hi all,
>>>>
>>>> Please review the fix for the bug:  JDK-8132376: Add @requires
>>>> os.family to the client tests with access to internal OS-specific
>>>> API
>>>>
>>>> BUG ID -*https://bugs.openjdk.java.net/browse/JDK-8132376*
>>>>      
>>>> The webrev is:http://cr.openjdk.java.net/~sgupta/8132376/webrev.01/
>>>> <http://cr.openjdk.java.net/%7Esgupta/8132376/webrev.01/>
>>>         - the copyright needs to be added to the new files
>>>         - the unnecessary staff for manual execution can be removed
>>> from tests which are made automated
>>>
>>>        Thanks,
>>>        Alexandr.
>>>
>>>>      
>>>>      
>>>> A couple of files(which are shown as new in the previous webrev) have been moved from ‘closed’ to ‘open’. The difference for those files in the closed repo can be found in the webrev:
>>>>      
>>>> http://cr.openjdk.java.net/~sgupta/8132376/webrev.00/
>>>> <http://cr.openjdk.java.net/%7Esgupta/8132376/webrev.00/>
>>>>
>>>> --
>>>> Regards,
>>>> Renjith Alexander
>>>>      
>>>>