<AWT Dev> Review request for JDK-7159591: [macosx] In SetFontTest there's no space for the second button.

[Sergey Bylokhov]

Looks fine.

On 04.12.15 16:12, Ambarish Rapte wrote:
> Hi Manjit,
>
>                  This fix looks fine to me.
>
>                  Does not make much visual difference in execution on
> other platforms. [Win, Linux]
>
> Thanks,
>
> Ambarish
>
> *From:*Manajit Halder
> *Sent:* Thursday, December 03, 2015 6:46 PM
> *To:* Ambarish Rapte; Semyon Sadetsky; awt-dev at openjdk.java.net
> *Subject:* Review request for JDK-7159591: [macosx] In SetFontTest
> there's no space for the second button.
>
> Hi All,
>
> Kindly review the fix for JDK9.
>
> *Bug*:
>
> https://bugs.openjdk.java.net/browse/JDK-7159591
>
> *Webrev*:
>
> http://cr.openjdk.java.net/~arapte/manajit/7159591/webrev.00/
>
> *Issue*: [macosx] In SetFontTest there's no space for the second button.
>
> *Cause*: It is observed that the default text font size (AWT List) and
> Button size (AWT Button) are bigger than that of on Windows.
>
> *Fix*: Changed the Height of the Applet window to 220 from 200. Since
> the default Text and Button sizes are bigger than that of the windows
> platform
>
> Other possible fixes:
>
> 1) Changing the default size of Text and Button on Mac OS X. This fix
> won’t be justified as there are no problems with the default Text and
> Button size.
>
> Only in this case the problem is observed because of the size of Applet
> window if fixed and there are no Scroll bar on the Applet Window.
>
> 2) Changing the Layout of the Applet window. Tried changing the Layout
> to BoxLayout. But there were some other issues with the alignment.
>
> 3) Changing the size of the List to 6 form 8. Since only 4 elements are
> added into the list. This fix is not justified because problem was with
> the size of the Applet window,
>
> not with the size of the List.
>
> Regards,
> Manajit
>


-- 
Best regards, Sergey.