<AWT Dev> <Awt Dev> [9] Review Request for 8145795: [TEST_BUG][PIT] java/awt/Window/ScreenLocation/ScreenLocationTest.java fails (can assign Integer.MAX_VALUE to Window dimensions)

Semyon Sadetsky semyon.sadetsky at oracle.com
Wed Dec 23 16:08:51 UTC 2015


Alexander, please clarify
1. will this fix the problem?
2. What if user uses value > Integer.MAX_VALUE / SCALE_FACTOR for window 
dimensions? If it should be prohibited now with your change, then we 
need to add this to all javadocs because window size does not meet its 
native limit in this case.

--Semyon

On 12/23/2015 6:41 PM, Alexander Scherbatiy wrote:
> On 12/22/2015 6:41 PM, Semyon Sadetsky wrote:
>> Right. This is regression of 8073320.
>> Fix is annulled. Thanks.
>
>   It would be better to update the test to take the scale factor into 
> the account.
>   Something like  A_BIG_SIZE = Integer.MAX_VALUE / SCALE_FACTOR.
>
>    Thanks,
>    Alexandr.
>
>>
>> --Semyon
>>
>> On 12/22/2015 6:03 PM, Yuri Nesterenko wrote:
>>> Semyon,
>>>
>>> but earlier builds of jdk9 could handle this bordercase properly,
>>> didn't they?. E.g. b95?
>>>
>>> -yan
>>>
>>> On 12/22/2015 04:22 PM, Semyon Sadetsky wrote:
>>>> Hello,
>>>>
>>>> Please review fix for JDK9:
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8145795
>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8145795/webrev.00/
>>>>
>>>> Windows do not accept  Integer.MAX_VALUE as dimension for internal
>>>> reasons. Twice less value works.
>>>>
>>>> --Semyon
>>>
>>
>



More information about the awt-dev mailing list