<AWT Dev> Review reuest for 8146168: [TEST_BUG] instability of java/awt/Frame/MaximizedToMaximized/MaximizedToMaximized.java

[Rajeev Chamyal]

Hello Ambarish,

 

1)      Please mark frameDisplayed & frameMaximized as volatile as these are accessed from different threads.

2)      Instead of disposing frame multiple times you can add a finally block.

3)      I think you can also remove the @author tag from test.

 

Regards,

Rajeev Chamyal

 

From: Ambarish Rapte 
Sent: 29 December 2015 10:58
To: Semyon Sadetsky; Prasanta Sadhukhan; Rajeev Chamyal; awt-dev at openjdk.java.net
Subject: Review reuest for 8146168: [TEST_BUG] instability of java/awt/Frame/MaximizedToMaximized/MaximizedToMaximized.java

 

Hi All,

Please review the fix for JDK9,

Webrev: http://cr.openjdk.java.net/~arapte/8146168/webrev.00/

Bug: https://bugs.openjdk.java.net/browse/JDK-8146168

 

Issue:

                The test fails, on low performance system.

 

Cause:

                The APIs, Frame.setVisible() & Frame.setExtendedState(Frame.MAXIMIZED_BOTH)

                take little more time to finish. Due to which the result verification occurs before above

                mentioned APIs complete.

                These APIs run on toolkit thread, But as the toolkit APIs should not be used by bug:

https://bugs.openjdk.java.net/browse/JDK-8063102

The original test was altered to remove ((SunToolkit) toolkit).realSync();

                

Fix:

                There are two fixes,

1.      Synchronize the calls

This is the fix in webrev.00 provided at above link.

Added ComponentAdapter  to synchronize Frame.setVisible()

Added WindowStateListener to synchronize Frame.setExtendedState(Frame.MAXIMIZED_BOTH)

 

2.      Add delay after call to above APIs

Adding robot.delay(1000) would also solve the issue.

If above fix 1: does not sound good, delay would do the same with lesser code change.

 

 

Merry Christmas,

Ambarish

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20151229/d0c70760/attachment.html>