<AWT Dev> [9] Review Request: 6475361 Attempting to remove help menu from java.awt.MenuBar throws NullPointerException

[Alexander Zvegintsev]

Hello Sergey,

the fix looks good to me.

Thanks,

Alexander.

On 01/12/2015 08:16 PM, Sergey Bylokhov wrote:
> Hello.
> Please review a fix for jdk 9.
> All problems mentioned in the CR were fixed:
>  - Menu.isHelpMenu will be changed to false when a menu is removed 
> from the MenuBar.
>  - MenuBar.helpMenu will be changed to null when a menu is removed 
> from the MenuBar.
>  - MenuBar.setHelpMenu now handle null w/o NPE. (Initially this code 
> behaved in the same way, but long long time ago in 1996 this 
> "m.parent" code was added outside of null check)
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-6475361
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/6475361/webrev.00
>