<AWT Dev> [9] Review request for 8068283: Mac OS Incompatibility between JDK 6 and 8 regarding input method handling

[Anton Nashatyrev]

Hi Sergey,

     actually this bug was detected by one of our tests (some Alt 
combinations worked some didn't) (see JDK-7144063 
<https://bugs.openjdk.java.net/browse/JDK-7144063>) but has been fixed 
in a way that all Alt combinations stopped working.
     Regarding the test - I'm not completely sure what do you want it to 
test, the Swing text components still works in a bit strange way on Mac: 
e.g. when pressing Alt-T both the action is executed and the cross 
symbol is appended to the text. Testing all Alt combinations is also not 
feasible since it's layout dependent - some of them should start input 
method and the action shouldn't be executed.
     The aim of this fix is to make awt sending KeyEvents instead of 
InputEvents when it is possible on Mac

Thanks!
Anton.

On 21.01.2015 17:30, Sergey Bylokhov wrote:
> Hi, Anton.
> >
> >     this is completely AWT bug and I'm using Swing components for 
> testing only. This fix gives the _possibility_ to handle <Alt>+Char 
> accelerator on Mac with any text component (filer >     uses it's own 
> component and LaF). So I don't think there is too much sense to check 
> all available JDK LaFs in this concrete fix.
>
> This bug wasn't found by our tests, which means that we didn't test 
> this functionality. As this error was such serious it would be quite 
> good to check this functionality with all l&f. Probably something does 
> not work on Nimbus, etc...
>
> >
> > Thanks!
> > Anton.
> >
> > P.S. Sorry, I've already pushed the fix before receiving your comment
> >
> > On 20.01.2015 20:09, Sergey Bylokhov wrote:
> >
>
>     > As this bug became so critical I suggest to test all supported
>     l&f in the test.
>     >
>     > On 20.01.2015 18:42, Anton Nashatyrev wrote:
>     >
>
>         Hello Alexander, Anton
>         >
>         >     could you please review the following fix:
>         >
>         > fix:
>         http://cr.openjdk.java.net/~anashaty/8068283/9/webrev.00/
>         <http://cr.openjdk.java.net/%7Eanashaty/8068283/9/webrev.00/>
>         > bug: https://bugs.openjdk.java.net/browse/JDK-8068283
>         >
>         >     Problem: No ways for keyboard shortcuts like <Alt> +
>         Char on Mac OS
>         >
>         >     Fix: Change the fix approach for the bug JDK-7144063
>         <https://bugs.openjdk.java.net/browse/JDK-7144063> which has
>         changed the behavior of the original Apple JDK port.
>         >
>         > Thanks!
>         > Anton.
>         > 
>
>
>     >
>     >
>
>     -- 
>     Best regards, Sergey.
>
>
> >

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20150121/f68454d8/attachment.html>