<AWT Dev> [9] Review Request for 8130125: [TEST_BUG] add @modules to the several client tests unaffected by the automated bulk update

[Alexander Scherbatiy]

   The fix looks good to me.

   Thanks,
   Alexandr.

On 7/3/2015 4:56 PM, Yuri Nesterenko wrote:
> OK, thank you Sergey,
>
> I'll remove bug8075609 from this changeset.
> I hope I can push this pure test fix with your single approval?
>
> -yan
>
> On 07/03/2015 04:45 PM, Sergey Bylokhov wrote:
>> Hi, Yuri.
>> The fix looks fine. But I suggest to move bug8075609 to the separate
>> issue to be sure that we do not break the fix for 8075609(at least the
>> test should check what component should has a focus).
>>
>> On 02.07.15 17:35, Yuri Nesterenko wrote:
>>> Hi,
>>>
>>> could you please take a look at the 2nd version:
>>>
>>> http://cr.openjdk.java.net/~yan/8130125/webrev.01
>>>
>>> Bug is here:
>>> https://bugs.openjdk.java.net/browse/JDK-8130125
>>>
>>> Thanks,
>>> -yan
>>>
>>>
>>> On 07/02/2015 04:50 PM, Yuri Nesterenko wrote:
>>>> On 07/02/2015 03:57 PM, Sergey Bylokhov wrote:
>>>>> Hi, Yuri.
>>>>>   - bug6980209.java can use some public logging?
>>>>>   - FocusEmbeddedFrameTest/ JButtonInGlassPaneOverlapping/etc why it
>>>>> needs a peer?
>>>> It's UtilInternal needs it, and that helper should be fixed
>>>> in Jake by addExports.
>>>>
>>>>>   - JSplitPaneOverlapping please split the long description
>>>>>   - bug6608456 why it needs com.sun.java.swing?
>>>> That's for SwingUtilities3 (sic)!
>>>>
>>>> I'll be back with logging and description.
>>>>
>>>> Thank you!
>>>>
>>>> -yan
>>>>
>>>>>
>>>>> On 02.07.15 13:55, Yuri Nesterenko wrote:
>>>>>> Colleagues,
>>>>>>
>>>>>> please review this test change:
>>>>>> http://cr.openjdk.java.net/~yan/8130125/webrev.00/
>>>>>>
>>>>>> In the most of the tests just @modules directive added;
>>>>>> other than that, see a short comment in
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8130125
>>>>>>
>>>>>> Also I'd like to piggyback in the push 3 tests
>>>>>> moved from closed part in already approved
>>>>>> http://cr.openjdk.java.net/~yan/8081306/
>>>>>> I forgot to do 'hg add', sorry.
>>>>>>
>>>>>> Thank you!
>>>>>> -yan
>>>>>
>>>>>
>>>>> -- 
>>>>> Best regards, Sergey.
>>>>>
>>>>
>>>
>>
>>
>