<AWT Dev> <Awt Dev> [9] Review Request for 8017487: filechooser in Windows-Libraries folder: columns are mixed up

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Jun 2 16:40:36 UTC 2015


ok, then the fix looks fine.

On 02.06.15 18:05, Semyon Sadetsky wrote:
> Hi Sergey,
>
> For test I would leave it as it is since there are no public methods 
> and since this is the official way to distinct libraries registered in 
> the system. It can help to detect inconsistencies.
>
> --Semyon
>
> On 6/2/2015 5:11 PM, Sergey Bylokhov wrote:
>> On 01.06.15 11:45, Semyon Sadetsky wrote:
>>> Hi Sergey,
>>>
>>> Not 100% sure that "Libraries" is not localized. So, I have excluded 
>>> it:
>> Then probably the test should be updated also?
>>
>>>  http://cr.openjdk.java.net/~ssadetsky/8017487/webrev.01/
>>>
>>> --Semyon
>>>
>>> On 5/29/2015 1:28 PM, Sergey Bylokhov wrote:
>>>> Hi,
>>>> The fix looks fine, except "Libraries" text. Does it mean that the 
>>>> same text is used in all locales?
>>>>
>>>> On 26.05.15 8:09, Semyon Sadetsky wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> Please review fix for JDK9:
>>>>>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8017487
>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8017487/webrev.00/
>>>>>
>>>>> File details view columns obtained by the legacy special folder 
>>>>> API for
>>>>> the virtual Windows libraries are not consistent with child files 
>>>>> inside
>>>>> those libraries.
>>>>> The details can be obtained only using new Windows APIs since MS 
>>>>> stops
>>>>> to support the old API for the new Windows libraries.
>>>>> The fix redirects column details requests for Windows Libraries to 
>>>>> their
>>>>> real file system locations.
>>>>>
>>>>> --Semyon
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>


-- 
Best regards, Sergey.



More information about the awt-dev mailing list