<AWT Dev> [9] Review request for 8068886: IDEA IntelliJ crashes in objc_msgSend when an accessibility tool is enabled

[Andrew Brygin]

Hi Anton,

  the fix looks fine to me.

Thanks,
Andrew

On 5/25/2015 1:57 PM, Anton Nashatyrev wrote:
> Hi Sergey,
>
>     thanks for review!
>
> Could anybody else take a look at the fix?
>
> Thanks!
> Anton.
>
> On 15.05.2015 21:27, Sergey Bylokhov wrote:
>> Hi, Anton.
>> Thanks, the fix looks fine.
>>>     I've sent you two suspects, but if this needs to fixed as well I 
>>> suggest to make it under another bug.
>> ok, I'll take look at it.
>>>
>>> Thanks!
>>> Anton.
>>>
>>> On 12.05.2015 21:32, Sergey Bylokhov wrote:
>>>> Hi, Anton.
>>>> The fix looks fine, but I suggest to document the new resources 
>>>> deallocation policy. I suppose documentation of loops, 
>>>> CFRetainedResource, etc should be updated.
>>>> Also please confirm that all our code follow this rule.
>>>>
>>>> On 08.05.15 19:52, Anton Nashatyrev wrote:
>>>>> Hello,
>>>>>     could you please review the following fix:
>>>>>
>>>>> fix: http://cr.openjdk.java.net/~anashaty/8068886/webrev.00/ 
>>>>> <http://cr.openjdk.java.net/%7Eanashaty/8068886/webrev.00/>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8068886
>>>>>
>>>>>     Problem: the native window pointer is disposed in the inner 
>>>>> AppKit loop, while it is still referenced on the stack in the 
>>>>> native Cocoa method which caused the mentioned inner loop. When 
>>>>> the inner loop is exited Cocoa crashes while dereferencing this 
>>>>> window pointer
>>>>>
>>>>>     Fix: dispose resources in the main AppKit loop only. For this 
>>>>> a 'dispose message' posted which is processed only on the main loop.
>>>>>
>>>>> Thanks!
>>>>> Anton.
>>>>
>>>>
>>>> -- 
>>>> Best regards, Sergey.
>>>
>>
>>
>> -- 
>> Best regards, Sergey.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20150604/489d6962/attachment.html>