<AWT Dev> [9] Review Request for 8081306: remove imports of the internal API from some regression tests
Yuri Nesterenko
yuri.nesterenko at oracle.com
Wed Jun 17 13:05:16 UTC 2015
Oh yes, thank you!
I thought for a moment about the open tests where I didn't
change last copyright date: this change seemed to be smallest
imaginable (well, other than bulk copyright update).
-yan
On 06/17/2015 03:51 PM, Sergey Bylokhov wrote:
> I just realized that you added a gpl headers in the moved tests, but the
> webrev.diff does not contain this.
> So the fix looks fine.
>
> On 17.06.15 15:47, Sergey Bylokhov wrote:
>> Hi, Yuri.
>> I think you should update the copyrights also.
>>
>> On 17.06.15 15:30, Yuri Nesterenko wrote:
>>> Colleagues,
>>>
>>> please review this test fix to
>>> https://bugs.openjdk.java.net/browse/JDK-8081306
>>>
>>> Webrev
>>> http://cr.openjdk.java.net/~yan/8081306/webrev.00
>>> closed tests moved to open, diffs:
>>> http://cr.openjdk.java.net/~yan/8081306/webrev.diff.00
>>>
>>> From the tests removed some unused import instructions.
>>> Without modular system in place, this is a meaningless
>>> change, however with modular discipline they
>>> just don't compile.
>>>
>>> Thank you!
>>>
>>> -yan
>>
>>
>
>
More information about the awt-dev
mailing list