<AWT Dev> [9] Review request for 8080504: [macosx] SunToolkit.realSync() may hang

[Phil Race]

On 06/24/2015 12:26 PM, Sergey Bylokhov wrote:
> Hi, Anton.
>  - Why the timeout is used as an int?

I agree that seems wrong. The downcast from long to int
could even result in the int being "-1" .. which would be
the infinite timeout - although I am not sure who would
wait around to see the difference :-)


-phil.

>  - Will the fix conform to this statement in the documentation of 
> ST.realSync()?
> @param timeout the maximum time to wait in milliseconds,*negative 
> means "forever"*.
> But I am not sure that all our implementations works in case of 
> negative timeout.
>
> On 23.06.15 20:31, Anton Nashatyrev wrote:
>> Hello,
>>     could you please review the following fix:
>>
>> fix: http://cr.openjdk.java.net/~anashaty/8080504/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Eanashaty/8080504/webrev.00/>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8080504
>>
>>     Problem: under MacOS X the realSync() may hang under some 
>> circumstances.
>>
>>     Fix:  make the Java_sun_lwawt_macosx_LWCToolkit_nativeSyncQueue 
>> method respecting timeout argument
>>
>> Thanks!
>> Anton.
>
>
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20150624/2a3bc86b/attachment.html>