<AWT Dev> [9] review request for 8072769: System tray icon title freezes java

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Mar 3 12:51:58 UTC 2015


  The fix looks good to me.

  Thanks,
  Alexandr.

On 3/3/2015 3:32 PM, Semyon Sadetsky wrote:
> accepted.
> http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8072769/webrev.03/
>
>
> On 3/3/2015 1:16 PM, Alexander Scherbatiy wrote:
>>
>>  Just few comments about the test:
>>   - The test sets WindowsLookAndFeel and seems fails on non Windows 
>> platforms.
>>   - There is the second SystemTray.isSupported() check on line 49. 
>> Does it depends on L&F?
>>   - The copyright should be updated to 2015.
>>
>>  Thanks,
>>  Alexandr.
>>
>> On 3/2/2015 4:01 PM, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Test was added. Please review.
>>> webrev: 
>>> http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8072769/webrev.02/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8072769
>>>
>>>
>>> On 2/26/2015 10:46 AM, Semyon Sadetsky wrote:
>>>> fix updated: 
>>>> http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8072769/webrev.01/
>>>>
>>>> On 2/24/2015 12:12 PM, Semyon Sadetsky wrote:
>>>>> Hello,
>>>>> <AWT Dev> [9] review request for 8061636: Fix for JDK-7079254 
>>>>> changes behavior of MouseListener, MouseMotionListener
>>>>> please review the 
>>>>> fix:http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8072769/webrev/ 
>>>>>
>>>>>
>>>>> for the issue:https://bugs.openjdk.java.net/browse/JDK-8072769
>>>>>
>>>>> System tray icon title freezes java
>>>>>
>>>>> This fix contains:
>>>>> fix corner case: <buffer size> == <length of the string>
>>>>> for two string parameters:
>>>>> 1. balloon title string
>>>>> 2. balloon text string
>>>>>
>>>>> -- 
>>>>> Thanks,
>>>>>
>>>>> Semyon.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>



More information about the awt-dev mailing list