<AWT Dev> [9] Review request for 7081580: Specification for MouseInfo.getNumberOfButtons() doesn't contain info about "awt.mouse.numButtons"

[Semyon Sadetsky]

Sorry, Sergey. Still don't understand what you mean.
The issue is about*to do**mention* "awt.mouse.numButtons".
Now you are saying that there is no value to mention it for the first 
time in this spec. Doesn't it contradict to the request itself?
You couldn't be more specific on what do you want, could you?
The fix just adds one short statement to the spec.  Maybe you'll find it 
to be more productive to just rephrase as you want and write here.

Thank you!
--Semyon

On 3/12/2015 11:11 AM, Sergey Bylokhov wrote:
> Hi, Semyon.
> That's a specification which should be read as written. But if you 
> mean this is not the same things, then it is unclear what value will 
> be added to the description of "awt.mouse.numButtons" property, which 
> mentions in the specification for the first time. Since 
> getNumberOfButtons obtain something not specified from the getToolkit, 
> modify it somehow(w/o specification) and returns. See for example 
> Toolkit.getToolkit and Toolkit. areExtraMouseButtonsEnabled(). It is 
> not necessary write so specific specification but at least it should 
> be clear.
>
> It would be good to rephrase it somehow.
>
> 12.03.15 0:09, Semyon Sadetsky wrote:
>> Hi Sergey,
>>
>> I didn't find any mention in the new text that the method returns the 
>> same value as Tolkit.get... returns.
>> I'm not an expert in English but in my opinion "obtained by" verb 
>> doesn't state that the same value is returned without any handling.
>> Maybe you've mixed it up with "proxy"?
>>
>> Thanks,
>> --Semyon
>>
>>
>> On 3/12/2015 9:47 AM, Sergey Bylokhov wrote:
>>> Hi, Semyon.
>>> The fix in general is correct, but it adds an assertion that this 
>>> method should return the same values as Toolkit.get...
>>> And this is incorrect, and we can get a new CR that implementation 
>>> don't follow the specification. Probably we can simplify it and 
>>> state that we use numeric value from desktop property or something 
>>> like that?
>>>
>>> 11.03.15 22:52, Semyon Sadetsky wrote:
>>>> Hello,
>>>>
>>>> please review fix for jdk9.
>>>>
>>>> Webrev: 
>>>> http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/7081580/webrev.00/
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-7081580
>>>>
>>>> Thanks,
>>>> --Semyon
>>>
>>>
>>
>
>
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20150312/568cacfb/attachment-0001.html>